Skip to content

Revert two-pass transcript selection - #21

Merged
lisavader merged 1 commit into
mainfrom
two_pass_revert
Mar 27, 2026
Merged

Revert two-pass transcript selection#21
lisavader merged 1 commit into
mainfrom
two_pass_revert

Conversation

@lisavader

Copy link
Copy Markdown
Collaborator

The two-pass system was introduced to ensure all selected transcripts overlap the primary (longest) transcript, and also added more strict validation.
The overlap check is now handled downstream (in produce_genes).

In practice, the revalidation causes unintended drops of valid transcripts due to the asymmetry of is_valid_alternative.
An accepted transcript (compared to seed) may fail against the new primary, even if it is a legitimate isoform.

It's now reverted to single-pass selection:

  • Seed with earliest-start/highest-score candidate
  • Collect valid alternatives in score order (need to be valid against all already selected calls)
  • Sort by CDS length and return up to max_transcripts calls (first = longest call is primary)

This ensures that if there are multiple groups of structurally similar transcripts per locus, the best calls are kept per structural group.

@lisavader
lisavader requested a review from lhon as a code owner March 27, 2026 05:10
@lisavader
lisavader merged commit ba352db into main Mar 27, 2026
4 checks passed
@lisavader
lisavader deleted the two_pass_revert branch March 27, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant