Revert two-pass transcript selection - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-pass system was introduced to ensure all selected transcripts overlap the primary (longest) transcript, and also added more strict validation.
The overlap check is now handled downstream (in produce_genes).
In practice, the revalidation causes unintended drops of valid transcripts due to the asymmetry of is_valid_alternative.
An accepted transcript (compared to seed) may fail against the new primary, even if it is a legitimate isoform.
It's now reverted to single-pass selection:
This ensures that if there are multiple groups of structurally similar transcripts per locus, the best calls are kept per structural group.